[SPARK-49406][SQL][TESTS] Add three test cases for from_avro/to_avro from the perspective of GenericRecord
#47888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the perspective of `GenericRecord`
Contributor
Author
|
cc @MaxGekk |
MaxGekk
reviewed
Aug 28, 2024
| record | ||
| } | ||
|
|
||
| test("GenericRecord serialize/deserialize") { |
Member
There was a problem hiding this comment.
Does this test check Spark's code? If not, let's remove it.
| } | ||
| } | ||
|
|
||
| test("use `to_avro` to read GenericRecord(stored in `struct` datatype)") { |
Member
There was a problem hiding this comment.
to read? it should write, shouldn't it?
Contributor
Author
There was a problem hiding this comment.
I have refactored this code and it seems clearer now. Please help review it again in your free time, thanks!
panbingkun
changed the title
from_avro/to_avro from the perspective of GenericRecordfrom_avro/to_avro from the perspective of GenericRecord
MaxGekk
approved these changes
Aug 29, 2024
Member
|
+1, LGTM. Merging to master. |
Contributor
Author
Thanks @MaxGekk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add 3 test cases for
from_avro/to_avrofrom the perspective ofGenericRecord.Why are the changes needed?
Just to add test cases and help better understand these two functions:
from_avro&to_avro.Does this PR introduce any user-facing change?
No, only just supplementary test cases.
How was this patch tested?
Update existed UT.
Was this patch authored or co-authored using generative AI tooling?
No.