[SPARK-49534][CORE][FOLLOWUP] Update outdated code comments related to the AbstractCommandBuilder#isJarAvailable method
#48032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Sep 9, 2024
| * @return true if a file starting with "spark-hive_" is found, false otherwise | ||
| * @param jarsDir the directory to search for JAR files | ||
| * @param jarNamePrefix the prefix of the JAR file name to look for | ||
| * @return true if a JAR file with the specified prefix is found, false otherwise |
Contributor
Author
There was a problem hiding this comment.
cc @HyukjinKwon
I'm very sorry, I forgot to update the comments for this method before merging.
HyukjinKwon
approved these changes
Sep 9, 2024
Contributor
Author
|
Merged into master. Thanks @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr just updates the outdated code comments related to the
AbstractCommandBuilder#isJarAvailablemethod.Why are the changes needed?
Update outdated code comments.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No