Skip to content

[SPARK-49593][SS] Throw RocksDB exception to the caller on DB close if an error is seen #48068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anishshri-db wants to merge 3 commits into from
Closed

[SPARK-49593][SS] Throw RocksDB exception to the caller on DB close if an error is seen #48068

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fdc2a9
[SPARK-49593] Throw RocksDB exception to the caller on DB close
anishshri-db Sep 10, 2024
cdb3a75
Address comments
anishshri-db Sep 11, 2024
dfd142d
Misc fix
anishshri-db Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ class RocksDB(
logInfo(log"Loading ${MDC(LogKeys.VERSION_NUM, version)}")
try {
if (loadedVersion != version) {
closeDB()
closeDB(ignoreException = false)
// deep copy is needed to avoid race condition
// between maintenance and task threads
fileManager.copyFileMapping()
Expand Down Expand Up @@ -945,13 +945,17 @@ class RocksDB(
logInfo(log"Opened DB with conf ${MDC(LogKeys.CONFIG, conf)}")
}

private def closeDB(): Unit = {
private def closeDB(ignoreException: Boolean = true): Unit = {
if (db != null) {

// Cancel and wait until all background work finishes
db.cancelAllBackgroundWork(true)
// Close the DB instance
db.close()
if (ignoreException) {
// Close the DB instance
db.close()
} else {
// Close the DB instance and throw the exception if any
db.closeE()
}
db = null
}
}
Expand Down