[SPARK-49713][PYTHON][CONNECT] Make function count_min_sketch accept number arguments#48157
Closed
zhengruifeng wants to merge 9 commits intoapache:masterfrom
Closed
[SPARK-49713][PYTHON][CONNECT] Make function count_min_sketch accept number arguments#48157zhengruifeng wants to merge 9 commits intoapache:masterfrom
count_min_sketch accept number arguments#48157zhengruifeng wants to merge 9 commits intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
Sep 19, 2024
Member
There was a problem hiding this comment.
Would need a connect version as well.
Contributor
Author
There was a problem hiding this comment.
Good catch! let me add one for Scala client.
Contributor
Author
There was a problem hiding this comment.
@HyukjinKwon it seems we don't have a separate functions.scala for Scala client now, after a lot of refactoring?
HyukjinKwon
approved these changes
Sep 19, 2024
Member
There was a problem hiding this comment.
nit: , optional in the end?
xinrong-meng
approved these changes
Sep 19, 2024
5164098 to
078792f
Compare
56f5793 to
c08d9d9
Compare
Contributor
Author
|
thanks @dongjoon-hyun @xinrong-meng and @HyukjinKwon merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, Make function
count_min_sketchaccept number arguments;2, Make argument
seedoptional;3, fix the type hints of
eps/confidence/seedfromColumnOrNametoColumn, because they require a foldable value and actually do not accept column name:Why are the changes needed?
1, seed is optional in other similar functions;
2, existing type hint is
ColumnOrNamewhich is misleading since column name is not actually supportedDoes this PR introduce any user-facing change?
yes, it support number arguments
How was this patch tested?
updated doctests
Was this patch authored or co-authored using generative AI tooling?
no