Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Sep 20, 2024

What changes were proposed in this pull request?

The pr aims to delete ExpressionInfo[between] from gen-sql-api-docs.py to avoid duplication.

Why are the changes needed?

After the pr:
image

Does this PR introduce any user-facing change?

Yes, only for docs.

How was this patch tested?

Manually check.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Sep 20, 2024
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we preserve the version in since: 1.0.0?

@panbingkun
Copy link
Contributor Author

Should we preserve the version in since: 1.0.0?

That makes sense, let me update it.

@panbingkun
Copy link
Contributor Author

Should we preserve the version in since: 1.0.0?

Updated, thanks!

@panbingkun panbingkun marked this pull request as ready for review September 20, 2024 10:57
@MaxGekk
Copy link
Member

MaxGekk commented Sep 20, 2024

I believe Run / Run Docker integration tests is not related to the changes.

+1, LGTM. Merging to master.
Thank you, @panbingkun.

@MaxGekk MaxGekk closed this in 4d97574 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants