[SPARK-49930][SS] Ensure that socket updates are flushed on exception from the python worker#48418
Closed
anishshri-db wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-49930][SS] Ensure that socket updates are flushed on exception from the python worker#48418anishshri-db wants to merge 1 commit intoapache:masterfrom
anishshri-db wants to merge 1 commit intoapache:masterfrom
Conversation
…m the python worker
Contributor
Author
|
cc - @HeartSaVioR @WweiL - PTAL, thx ! |
HyukjinKwon
approved these changes
Oct 11, 2024
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure that socket updates are flushed on exception from the python worker
Why are the changes needed?
Without this, updates to the socket from the python worker are not delivered to the jvm side
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests were failing on a different Python version and pass after
Was this patch authored or co-authored using generative AI tooling?
No