Skip to content

[MINOR][CORE] Fix the regenerate command in SparkThrowableSuite#48432

Closed
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:fix-regenerateCommand
Closed

[MINOR][CORE] Fix the regenerate command in SparkThrowableSuite#48432
MaxGekk wants to merge 1 commit intoapache:masterfrom
MaxGekk:fix-regenerateCommand

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Oct 12, 2024

What changes were proposed in this pull request?

Fix the command in SparkThrowableSuite which regenerates/re-formats error-conditions.json.

Why are the changes needed?

To don't confuses other devs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the changes command:

$ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "core/testOnly *SparkThrowableSuite -- -t \"Error conditions are correctly formatted\""

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Oct 12, 2024
@MaxGekk MaxGekk changed the title [MINOR][CORE] Fix the regenerate command in SparkThrowableSuite [MINOR][CORE] Fix the regenerate command in SparkThrowableSuite Oct 12, 2024
@MaxGekk
Copy link
Member Author

MaxGekk commented Oct 14, 2024

Merging the trivial fix to master.

@MaxGekk MaxGekk closed this in a2ad4d4 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant