[SPARK-49982][SQL] Fix negative caching in InMemoryRelation#48486
Closed
liuzqt wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-49982][SQL] Fix negative caching in InMemoryRelation#48486liuzqt wants to merge 5 commits intoapache:masterfrom
liuzqt wants to merge 5 commits intoapache:masterfrom
Conversation
Member
|
cc @maryannxue |
cloud-fan
reviewed
Oct 23, 2024
...core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Oct 24, 2024
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Re-cache AQE plan upon failure.
Why are the changes needed?
When we use a cached an AQE plan, it will do
cachedPlan.executeto build the RDD, which will execute all AQE stages except the result stage. If any of them failed, the failure will be cached by lazy RDD val. So the next time when we reuse that cached plan (even by a totally irrelevant caller) it will fail immediately.We need to re-cache the AQE plan upon failure.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
new UT
Was this patch authored or co-authored using generative AI tooling?
NO