[SPARK-50010][SQL] Expand implicit collation mismatch error#48495
Closed
uros-db wants to merge 7 commits intoapache:masterfrom
Closed
[SPARK-50010][SQL] Expand implicit collation mismatch error#48495uros-db wants to merge 7 commits intoapache:masterfrom
uros-db wants to merge 7 commits intoapache:masterfrom
Conversation
uros-db
changed the title
uros-db
commented
Oct 17, 2024
Contributor
Author
uros-db
left a comment
uros-db
left a comment
There was a problem hiding this comment.
@mihailom-db please review
MaxGekk
requested changes
Oct 17, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
MaxGekk
requested changes
Oct 17, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
mihailomilosevic2001
approved these changes
Oct 17, 2024
Contributor
mihailomilosevic2001
left a comment
mihailomilosevic2001
left a comment
There was a problem hiding this comment.
LGTM, just a small nit comment
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Include the implicit string collations in the
COLLATION_MISMATCH.IMPLICITerror message.Why are the changes needed?
Make the implicit collation mismatch error more user-friendly.
Does this PR introduce any user-facing change?
Yes, implicit collation mismatch error is changed.
How was this patch tested?
Updated existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.