[SPARK-50029][SQL] Make StaticInvoke compatible with the method that return Any
#48542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
Oct 18, 2024
|
|
||
| test("StaticInvoke call return `any` method") { | ||
| val cls = TestStaticInvokeReturnAny.getClass | ||
| Seq((0, IntegerType, true), (1, IntegerType, true), (2, IntegerType, false)).foreach { |
Contributor
Author
There was a problem hiding this comment.
- case 0 -
(0, IntegerType, true)will hit line325ofobjects.scala - case 1 -
(1, IntegerType, true)will hit line332ofobjects.scala - case 2 -
(2, IntegerType, true)will hit line340ofobjects.scala
Contributor
Author
There was a problem hiding this comment.
This UT can hit three points where cast is added.
Contributor
Author
|
cc @cloud-fan |
cloud-fan
approved these changes
Oct 21, 2024
Contributor
|
thanks, merging to master! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Oct 22, 2024
…t return `Any` ### What changes were proposed in this pull request? The pr aims to make `StaticInvoke` compatible with the method that return `Any`. ### Why are the changes needed? Currently, our `StaticInvoke` does not support calling the method with a return type signature of `Any`(actually, the type of return value may be `different data type`), while `Invoke` supports it, let's align it. ### Does this PR introduce _any_ user-facing change? No, only for spark developer. ### How was this patch tested? - Add new UT. - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48542 from panbingkun/SPARK-50029. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to make
StaticInvokecompatible with the method that returnAny.Why are the changes needed?
Currently, our
StaticInvokedoes not support calling the method with a return type signature ofAny(actually, the type of return value may bedifferent data type), whileInvokesupports it, let's align it.Does this PR introduce any user-facing change?
No, only for spark developer.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.