[SPARK-50027][SQL] Move Identity Column SQL parsing code to DataTypeAstBuilder#48543
Closed
zhipengmao-db wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-50027][SQL] Move Identity Column SQL parsing code to DataTypeAstBuilder#48543zhipengmao-db wants to merge 3 commits intoapache:masterfrom
zhipengmao-db wants to merge 3 commits intoapache:masterfrom
Conversation
Member
|
can you fill the PR description please? |
MaxGekk
approved these changes
Oct 20, 2024
Member
|
+1, LGTM. Merging to master. |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Oct 22, 2024
…stBuilder ### What changes were proposed in this pull request? It moves code parsing Identity Column DDL from AstBuilder to DataTypeAstBuilder. ### Why are the changes needed? `DataTypeAstBuilder` is intended for parsing code of column definitions. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existent tests cover this. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48543 from zhipengmao-db/zhipengmao-db/id-column-refactor. Authored-by: zhipeng.mao <zhipeng.mao@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It moves code parsing Identity Column DDL from AstBuilder to DataTypeAstBuilder.
Why are the changes needed?
DataTypeAstBuilderis intended for parsing code of column definitions.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existent tests cover this.
Was this patch authored or co-authored using generative AI tooling?
No.