Skip to content

Conversation

@packyan
Copy link

@packyan packyan commented Oct 20, 2024

What changes were proposed in this pull request?

When I compiled the spark-core module in the windows environment, the bash/powershell program could not be executed because my operating system had WSL installed, and the build information file was not generated in the spark-core jar. When I used this jar for verification, I found that the jar was not working properly as the build information was not present.

Therefore, building should be stopped when Antrun script fails.

Why are the changes needed?

Based on my previous statement, I think when the antrun script in spark-core module fails, the build progress should be ended immediately, otherwise the builded spark-core.jar will not work properly.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Since it does not change the existing behavior and only covers abnormal scenarios, it is tested manually locally.

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the BUILD label Oct 20, 2024
@HyukjinKwon HyukjinKwon changed the title [SPARK-50043] Build should be stopped when Antrun script fails [SPARK-50043][BUILD] Build should be stopped when Antrun script fails Oct 22, 2024
@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jan 31, 2025
@github-actions github-actions bot closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant