[SPARK-50056][SQL] Codegen Support for ParseUrl (by Invoke & RuntimeReplaceable) #48579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
cloud-fan
reviewed
Nov 12, 2024
| case class ParseUrlEvaluator( | ||
| cachedUrl: () => URI, | ||
| cachedExtractPartFunc: URI => String, | ||
| cachedPattern: () => Pattern, |
Contributor
There was a problem hiding this comment.
it's better to not put lambda functions here as ParseUrlEvaluator will be serialized and sent to the executor side.
Can we pass the necessary basic information so that we can generate these lambda functions within ParseUrlEvaluator?
Contributor
Author
There was a problem hiding this comment.
Updated!
(PS: This is really a good suggestion. For myself, the code looks much better now, thanks! ❤️)
cloud-fan
approved these changes
Nov 12, 2024
Contributor
|
thanks, merging to master! |
Contributor
Author
Thanks! ❤️ |
Member
|
Thank you, @panbingkun and @cloud-fan . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add
CodegenSupport forparse_url.Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA & Existed UT (eg: UrlFunctionsSuite#
*parse_url*)Was this patch authored or co-authored using generative AI tooling?
No.