[SPARK-50119] Add user facing error for lambda functions outside of higher order functions#48658
Closed
dusantism-db wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-50119] Add user facing error for lambda functions outside of higher order functions#48658dusantism-db wants to merge 3 commits intoapache:masterfrom
dusantism-db wants to merge 3 commits intoapache:masterfrom
Conversation
MaxGekk
requested changes
Oct 25, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Consider to provide more relevant error condition.
| override def exprId: ExprId = throw new UnresolvedException("exprId") | ||
| override def dataType: DataType = throw new UnresolvedException("dataType") | ||
| override def dataType: DataType = throw new SparkRuntimeException( | ||
| errorClass = "INVALID_LAMBDA_FUNCTION_CALL.NON_HIGHER_ORDER_FUNCTION", |
Member
There was a problem hiding this comment.
Could you clarify, please, why do you propose the error condition. IMHO, it is related to the condition when Spark expects a higher-order function but got something else.
Looking at the test, you are trying to fix another situation when a higher-order functions is not expected at all.
|
|
||
| override def exprId: ExprId = throw new UnresolvedException("exprId") | ||
| override def dataType: DataType = throw new UnresolvedException("dataType") | ||
| override def dataType: DataType = throw new SparkRuntimeException( |
Member
There was a problem hiding this comment.
Sorry, why a runtime exception?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces a UnresolvedException throw with a user facing error. The error has a ? instead of class name of the class which contains the lambda, because at this point in execution we don't have that information
Why are the changes needed?
See https://issues.apache.org/jira/browse/SPARK-50119
Does this PR introduce any user-facing change?
Yes, different error is thrown for lambda function misuse
How was this patch tested?
Added unit test.
Was this patch authored or co-authored using generative AI tooling?
No