Skip to content

[SPARK-50125] Add new error class - Data source does not support DML operation #48660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
urosstan-db wants to merge 8 commits into from
Closed

[SPARK-50125] Add new error class - Data source does not support DML operation #48660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7fc7897
Add data source does not support DML operation error class
urosstan-db Oct 25, 2024
45261b2
Remove quoting on SQL operation
urosstan-db Oct 25, 2024
950ea4b
Add error state
urosstan-db Oct 25, 2024
1b0eb23
Change origin
urosstan-db Oct 25, 2024
cf2d5f9
Update golden file
urosstan-db Oct 29, 2024
8a9645e
Merge branch 'master' into add-new-error-condition
urosstan-db Oct 29, 2024
2e18b89
Update common/utils/src/main/resources/error/error-conditions.json
urosstan-db Oct 29, 2024
4fccc5d
Update common/utils/src/main/resources/error/error-states.json
urosstan-db Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,6 +1111,12 @@
],
"sqlState" : "42K03"
},
"DATA_SOURCE_UNSUPPORTED_DML_OPERATION" : {
Copy link
Member

@MaxGekk MaxGekk Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we removed DML from message, let's remove it from the condition name.

Copy link
Contributor Author

@urosstan-db urosstan-db Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to have it just exception dedicated to DML operations, if it is needed I can revert DML in message? Serge suggested me to do that

Copy link
Contributor

@srielau srielau Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be in sync with the name. So yes, I implied to remove it from both.

"message" : [
"Data source '<provider>' does not support the requested operation: <operation>"
],
"sqlState" : "KD011"
},
"DATETIME_OVERFLOW" : {
"message" : [
"Datetime operation overflow: <operation>."
Expand Down
6 changes: 6 additions & 0 deletions common/utils/src/main/resources/error/error-states.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7441,6 +7441,12 @@
"standard": "N",
"usedBy": ["Databricks"]
},
"KD011": {
"description": "external data source does not support operation",
"origin": "Spark",
"standard": "N",
"usedBy": ["Spark"]
},
"P0000": {
"description": "procedural logic error",
"origin": "PostgreSQL",
Expand Down