[TYPING] Add type overloads for inplace dataframe operations#48662
Closed
tigerhawkvok wants to merge 4 commits into
Closed
[TYPING] Add type overloads for inplace dataframe operations#48662tigerhawkvok wants to merge 4 commits into
tigerhawkvok wants to merge 4 commits into
Conversation
…ctly show a return of None or DataFrame based on flag state
Author
|
The lint error for this PR is an open MyPy bug: |
Member
|
cc @itholic |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type overloads for inplace dataframe operationsctly show a return of None or DataFrame based on flag state.
Additionally adds one small type check function,
validate_strict_bool()to wrapvalidate_bool_kwargs()forinplace, asvalidate_bool_kwargs()acceptsboolorNone; butinplacecan only bebool.Aside from that very minor function edit, all other changes are exclusively to type hints.
Simple test case:
Before:
The union is returned regardless of state of
inplaceAfter:
inplaceis implicitly or explicitlyTruereturns aDataFrameinplaceis explicitlyFalsereturnsNoneinplaceis ambiguous and eitherTrueorFalse, still returnsUnion[DataFrame, None]