[SPARK-50313][SQL][TESTS] Enable ANSI in SQL *SQLQueryTestSuite by default #48842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
commented
Nov 15, 2024
| -- Type Coerced Union | ||
| SELECT udf(c1) as c1, udf(c2) as c2 | ||
| FROM (SELECT udf(c1) as c1, udf(c2) as c2 FROM t1 | ||
| FROM (SELECT udf(c1) as c1, udf(c2) as c2 FROM t1 WHERE c2 = 'a' |
yaooqinn
commented
Nov 15, 2024
| values (0, 1) tab(x, y) | ||
| |> union table t; | ||
| |> union table t | ||
| |> where x = 0; |
yaooqinn
commented
Nov 15, 2024
|
|
||
| -- test decimal operations | ||
| select id, a+b, a-b, a*b, a/b from decimals_test order by id; | ||
| select /*+ COALESCE(1) */ id, a+b, a-b, a*b, a/b from decimals_test order by id; |
Member
Author
|
cc @dongjoon-hyun as the initiator of SPARK-44444, also cc @cloud-fan, thank you |
dongjoon-hyun
approved these changes
Nov 15, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making this efforts, @yaooqinn . It looks reasonable to me.
Although it's too verbose due to the switching the directory locations, I believe it's okay because we need to regenerate the SQL result always when we are going to backport from branch-4.0 to branch-3.5.
MaxGekk
reviewed
Nov 15, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
cc @mihailom-db who works on https://issues.apache.org/jira/browse/SPARK-49577 and @srielau
Member
Author
|
Merged to master, thank you @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enables ANSI in SQL *SQLQueryTestSuite by default for regular tests and switches the original ansi/ ones to nonansi, following SPARK-44444, which turn on ansi for prod,
Why are the changes needed?
test improvements
Does this PR introduce any user-facing change?
no
How was this patch tested?
new golden files
Was this patch authored or co-authored using generative AI tooling?
no