Skip to content

[SPARK-50313][SQL][TESTS][FOLLOWUP] Regenerate golden files for Java 21 #48886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LuciferYang wants to merge 3 commits into from
Closed

[SPARK-50313][SQL][TESTS][FOLLOWUP] Regenerate golden files for Java 21 #48886

LuciferYang wants to merge 3 commits into from

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Nov 19, 2024 •
edited
Loading

What changes were proposed in this pull request?

This pr uses the command

java -version
openjdk version "21.0.5" 2024-10-15 LTS
OpenJDK Runtime Environment Zulu21.38+21-CA (build 21.0.5+11-LTS)
OpenJDK 64-Bit Server VM Zulu21.38+21-CA (build 21.0.5+11-LTS, mixed mode, sharing)

SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"

to regenerate golden files for Java 21.

Why are the changes needed?

Regenerate golden files for Java 21.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

LuciferYang
LuciferYang commented Nov 19, 2024
View reviewed changes
.github/workflows/build_and_test.yml Outdated
required: false
type: string
default: 17
default: 21
Copy link
Contributor Author

@LuciferYang LuciferYang Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert after test

Copy link
Contributor Author

@LuciferYang LuciferYang Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @yaooqinn FYI

Copy link
Contributor Author

@LuciferYang LuciferYang Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

reverted

@github-actions github-actions bot removed the INFRA label Nov 19, 2024
@LuciferYang
Copy link
Contributor Author

LuciferYang commented Nov 19, 2024

Merged into master for Spark 4.0. Thanks @yaooqinn @HyukjinKwon and @panbingkun

@LuciferYang LuciferYang deleted the SPARK-50313-FOLLOWUP branch May 2, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@yaooqinn yaooqinn yaooqinn approved these changes

@panbingkun panbingkun panbingkun approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LuciferYang @HyukjinKwon @yaooqinn @panbingkun