[SPARK-50465][PYTHON][TESTS] Use assertDataFrameEqual in pyspark.sql.tests.test_group and test_readwriter#49023
Closed
xinrong-meng wants to merge 1 commit into
Closed
[SPARK-50465][PYTHON][TESTS] Use assertDataFrameEqual in pyspark.sql.tests.test_group and test_readwriter#49023xinrong-meng wants to merge 1 commit into
xinrong-meng wants to merge 1 commit into
Conversation
dongjoon-hyun
approved these changes
Dec 2, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @xinrong-meng .
Merged to master for Apache Spark 4.0.0 on February 2025.
Member
|
BTW, how many test PRs are you going to open, @xinrong-meng ? Do you think we can do that in a single batch instead of many small ones like this? |
Member
Author
|
Thanks @dongjoon-hyun , certainly, I will handle the rest in a single batch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
assertDataFrameEqualin pyspark.sql.tests.test_group and test_readwriterWhy are the changes needed?
assertDataFrameEqualis explicitly built to handle DataFrame-specific comparisons, including schema.So we propose to replace
assertEqualwithassertDataFrameEqualPart of https://issues.apache.org/jira/browse/SPARK-50435.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.