[SPARK-49349][SQL][FOLLOWUP] Rename isContainsUnsupportedLCA function #49134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
MaxGekk
reviewed
Dec 10, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Could you replace the tag [Minor] by [SPARK-49349][SQL][FOLLOWUP], please.
tedyu
changed the title
Contributor
Author
|
@MaxGekk |
HyukjinKwon
reviewed
Dec 11, 2024
| } | ||
|
|
||
| private def isContainsUnsupportedLCA(e: Expression, operator: LogicalPlan): Boolean = { | ||
| private def containsUnsupportedLCA(e: Expression, operator: LogicalPlan): Boolean = { |
Member
There was a problem hiding this comment.
Let's avoid having such typo fixes ... .this is really something we can easily fix when we happen to touch those codes later...
Contributor
Author
There was a problem hiding this comment.
bq. when we happen to touch those codes later
Agreed
Member
|
gonna merge this as the PR is open already. |
HyukjinKwon
approved these changes
Dec 11, 2024
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As follow-up to #48915, this PR renames
isContainsUnsupportedLCAfunctionWhy are the changes needed?
The renamed function is easier to understand.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No change in functionality.
Existing tests suffice.
Was this patch authored or co-authored using generative AI tooling?
No