[WIP][SPARK-24497][SQL] An initial, no-op commit that makes a number... #49146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to add recursive CTEs. With an overarching goal to break the old PR into manageable segments, this is an initial commit that makes a number of changes in CTESubstitution.scala that are self-contained and that make CTE substitions and resolutions aware of the recursion. We also make minimal, no-op changes in basicLogicalOperators.scala.
nemanjapetr-db
changed the title
nemanjapetr-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... of changes in CTESubstitution.scala that are self-contained and that make CTE substitions and resolutions aware of the recursion. We also make minimal, no-op changes in basicLogicalOperators.scala.
What changes were proposed in this pull request?
Some initial no-op changes required to implement a recursive CTE.
https://docs.google.com/document/d/1qcEJxqoXcr5cSt6HgIQjWQSqhfkSaVYkoDHsg5oxXp4/edit
Why are the changes needed?
Support for the recursive CTE.
Does this PR introduce any user-facing change?
No. RECURSIVE keyword is not introduced in this PR.
How was this patch tested?
This commit trivially breaks a number of tests (~17) and requires a large number of trivial test changes due to new parameters introduced in ctors of CTERelationDef and CTERelationRef. Hence, it should be merged only after another PR that introduces ctor changes and fixes the corresponding tests.
Was this patch authored or co-authored using generative AI tooling?
No