[SPARK-49632][SQL][FOLLOW-UP] Fix suggestion for to_date function#49290
Closed
mihailomilosevic2001 wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-49632][SQL][FOLLOW-UP] Fix suggestion for to_date function#49290mihailomilosevic2001 wants to merge 5 commits intoapache:masterfrom
to_date function#49290mihailomilosevic2001 wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@MaxGekk could you take a look at this follow-up? |
cloud-fan
approved these changes
Dec 25, 2024
HyukjinKwon
approved these changes
Dec 26, 2024
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change of suggested function on failure from
try_to_timestamptotry_to_dateforto_datefunction.Why are the changes needed?
In original PR #49227 we removed ANSI suggestion and left only a suggestion of try function to use. In case of
to_date, use oftry_to_dateis more appropriate.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Existing tests scope error message change.
Was this patch authored or co-authored using generative AI tooling?
No.