Skip to content

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Mar 9, 2015

This PR expands the Python lint checks so that they check for obvious compilation errors in our Python code.

For example:

$ ./dev/lint-python 
Python lint checks failed.
Compiling ./ec2/spark_ec2.py ...
  File "./ec2/spark_ec2.py", line 618
    return (master_nodes,, slave_nodes)
                         ^
SyntaxError: invalid syntax

./ec2/spark_ec2.py:618:25: E231 missing whitespace after ','
./ec2/spark_ec2.py:1117:101: E501 line too long (102 > 100 characters)

This PR also bumps up the version of pep8. It ignores new types of checks introduced by that version bump while fixing problems missed by the older version of pep8 we were using.

@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28375 has started for PR 4941 at commit 75e31d8.

  • This patch merges cleanly.

@nchammas
Copy link
Contributor Author

nchammas commented Mar 9, 2015

cc @JoshRosen @davies

@SparkQA
Copy link

SparkQA commented Mar 9, 2015

Test build #28375 has finished for PR 4941 at commit 75e31d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28375/
Test PASSed.

@JoshRosen
Copy link
Contributor

LGTM. I'm going to let Jenkins retest this again and will merge once tests pass.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Mar 19, 2015

Test build #28880 has started for PR 4941 at commit 75e31d8.

  • This patch merges cleanly.

@davies
Copy link
Contributor

davies commented Mar 19, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Mar 19, 2015

Test build #28880 has finished for PR 4941 at commit 75e31d8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28880/
Test PASSed.

@asfgit asfgit closed this in f17d43b Mar 19, 2015
@nchammas nchammas deleted the compile-spark-ec2 branch March 19, 2015 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants