Skip to content

[SPARK-50787][DOCS] Fix typos and add missing semicolons in sql examples#49448

Closed
the-sakthi wants to merge 1 commit intoapache:masterfrom
the-sakthi:fix-docs
Closed

[SPARK-50787][DOCS] Fix typos and add missing semicolons in sql examples#49448
the-sakthi wants to merge 1 commit intoapache:masterfrom
the-sakthi:fix-docs

Conversation

@the-sakthi
Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

  • Corrected documentation typos
  • Added missing semicolons in SQL examples

Why are the changes needed?

To correct documentation typos and fix SQL syntax examples for clarity.

Does this PR introduce any user-facing change?

Yes, it updates documentation with corrections to typos and SQL examples.

How was this patch tested?

Manually, by building and reviewing the updated documentation.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Jan 10, 2025
@dongjoon-hyun dongjoon-hyun changed the title [MINOR][DOCS][SPARK-50787] Fix typos and add missing semicolons in sql examples [SPARK-50787][DOCS] Fix typos and add missing semicolons in sql examples Jan 10, 2025
@the-sakthi the-sakthi marked this pull request as ready for review January 10, 2025 21:09
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @the-sakthi .

Just FYI, [MINOR] is used only when we don't have a corresponding JIRA issue.
In other words, it's used instead of [SPARK-XXXXX]. So, you don't need to put both in the same PR title. 😄

Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@the-sakthi
Copy link
Copy Markdown
Member Author

Ahh gotcha @dongjoon-hyun
Thanks for the information. Will keep in mind for the future.
Appreciate the approval !

@the-sakthi
Copy link
Copy Markdown
Member Author

@dongjoon-hyun could you help with the merge of the PR as well, please?

@MaxGekk
Copy link
Copy Markdown
Member

MaxGekk commented Jan 11, 2025

+1, LGTM. Merging to master.
Thank you, @the-sakthi and @dongjoon-hyun for review.

@MaxGekk MaxGekk closed this in f0f850d Jan 11, 2025
@MaxGekk
Copy link
Copy Markdown
Member

MaxGekk commented Jan 11, 2025

@the-sakthi Congratulations with your first contribution to Apache Spark!

@the-sakthi
Copy link
Copy Markdown
Member Author

Thanks for all the help here, @MaxGekk and @dongjoon-hyun !

@dongjoon-hyun
Copy link
Copy Markdown
Member

Thank YOU, @the-sakthi and @MaxGekk ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants