-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-50633][FOLLOWUP] Let CODECOV_TOKEN transfer to build_and_test.yml
#49507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rage.yml` to `build_and_test.yml`
|
cc @dongjoon-hyun @HyukjinKwon @zhengruifeng @LuciferYang |
.github/workflows/build_and_test.yml
Outdated
| uses: codecov/codecov-action@v5 | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
| CODECOV_TOKEN: ${{ inputs.codecov_token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this change, will inputs.codecov_token be in plaintext?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the current approach, token is no longer plaintext.
|
Just want to check. According to the commit log and CI result, this isn't ready yet. Did I understand correctly, @panbingkun ? |
the following error will occur
@HyukjinKwon, do you know what the possible reasons could be?
|
|
@dongjoon-hyun |
CODECOV_TOKEN transfer from build_coverage.yml to build_and_test.ymlCODECOV_TOKEN transfer to build_and_test.yml
https://github.com/panbingkun/github-actions/actions/runs/12804808017/job/35700210844
|
| secrets: | ||
| codecov_token: | ||
| description: The upload token of codecov. | ||
| required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the previous issue was whether codecov_token shouldn't specify default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type and default cannot be set in secrets, otherwise an error will be reported.
|
hmm... can we make a clean one? |
Okay |
|
closing in favor of #49527 |







What changes were proposed in this pull request?
The pr aims to let
CODECOV_TOKENtransfer frombuild_coverage.yml/build_main.ymltobuild_and_test.yml.Why are the changes needed?
Currently,
codecov/codecov-actionis unable to obtainCODECOV_TOKEN.I checked and it seems that the usage below is similar to ours.
https://stackoverflow.com/questions/78298827/why-is-codecov-upload-step-in-github-actions-not-finding-the-token
Let's continue to try it out.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually check.
Was this patch authored or co-authored using generative AI tooling?
No.