Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 17, 2025

What changes were proposed in this pull request?

This PR aims to limit GHA job execution time to up to 2 hours.

Why are the changes needed?

To prevent a silent regression in terms of the GitHub Action execution time.

Does this PR introduce any user-facing change?

No, this is a infra-only change.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Jan 17, 2025
@HyukjinKwon
Copy link
Member

I wonder if 2 hours is too short ....

@dongjoon-hyun
Copy link
Member Author

According to my observation, I guess the above pytorch and TPCDS job could hit the limit.

Let's see. I'll re-trigger again after the above PR is merged.

@dongjoon-hyun
Copy link
Member Author

Thank you!

@dongjoon-hyun
Copy link
Member Author

Thank you all. I just rebased this to the master to bring SPARK-50863 .

@dongjoon-hyun
Copy link
Member Author

All tests passed.
Screenshot 2025-01-16 at 23 04 47

dongjoon-hyun added a commit that referenced this pull request Jan 17, 2025
### What changes were proposed in this pull request?

This PR aims to limit GHA job execution time to up to 2 hours.

### Why are the changes needed?

To prevent a silent regression in terms of the GitHub Action execution time.
- #49539

### Does this PR introduce _any_ user-facing change?

No, this is a infra-only change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49544 from dongjoon-hyun/SPARK-50866.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 3b0ac45)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Merged to master/4.0.

Thank you again, @HyukjinKwon , @zhengruifeng , @LuciferYang .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50866 branch January 17, 2025 07:06
@dongjoon-hyun dongjoon-hyun mentioned this pull request Aug 6, 2025
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
### What changes were proposed in this pull request?

This PR aims to limit GHA job execution time to up to 2 hours.

### Why are the changes needed?

To prevent a silent regression in terms of the GitHub Action execution time.
- apache#49539

### Does this PR introduce _any_ user-facing change?

No, this is a infra-only change.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49544 from dongjoon-hyun/SPARK-50866.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 63008c7)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants