[SPARK-50718][PYTHON] Support addArtifact(s) for PySpark#49572
Closed
itholic wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-50718][PYTHON] Support addArtifact(s) for PySpark#49572itholic wants to merge 5 commits intoapache:masterfrom
addArtifact(s) for PySpark#49572itholic wants to merge 5 commits intoapache:masterfrom
Conversation
itholic
commented
Jan 20, 2025
| import os | ||
| import tempfile | ||
|
|
||
| from pyspark.sql.tests.connect.client.test_artifact import ArtifactTestsMixin |
Contributor
Author
There was a problem hiding this comment.
Use pyspark.sql.tests.connect.client.test_artifact.ArtifactTestsMixin here to ensure the same testing as Spark Connect
Member
There was a problem hiding this comment.
I think ArtifactTestsMixin has to be located to here.
Contributor
Author
There was a problem hiding this comment.
Could I address the relocation as a follow-up? I have some plan to restructure overall test_artifact.py across Classic and Connect.
itholic
commented
Jan 20, 2025
| with open(pyfile_path, "w+") as f: | ||
| f.write("my_func = lambda: 11") | ||
|
|
||
| with self.assertRaises(PySparkRuntimeError) as pe: |
Contributor
Author
There was a problem hiding this comment.
FYI: Spark Connect raises SparkConnectGrpcException instead of PySparkRuntimeError here.
I think it would be good to find more cases like this and capture them as a same base error to keep consistency between Classic and Connect.
HyukjinKwon
reviewed
Jan 20, 2025
HyukjinKwon
reviewed
Jan 20, 2025
HyukjinKwon
reviewed
Jan 20, 2025
| if os.path.exists(target_dir): | ||
| # Compare the contents of the files. If identical, skip adding this file. | ||
| # If different, raise an exception. | ||
| if filecmp.cmp(normalized_path, target_dir, shallow=False): |
Member
There was a problem hiding this comment.
To be clear, is this the same behaviour with Spark Classic, right?
Contributor
Author
There was a problem hiding this comment.
Yes, this matches behavior with Spark Connect Python client and Spark Core
HyukjinKwon
approved these changes
Jan 21, 2025
itholic
added a commit
to itholic/spark
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? This PR proposes to support `addArtifact(s)` for PySpark ### Why are the changes needed? For feature parity with Spark Connect ### Does this PR introduce _any_ user-facing change? No API changes, but adding new API `addArtifact(s)` ### How was this patch tested? Added corresponding UTs with Spark Connect ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49572 from itholic/add_artifacts. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Haejoon Lee <haejoon.lee@databricks.com>
Contributor
Author
|
Merged to master and created separate PR for branch-4.0: #49583. Thanks @HyukjinKwon for the review. |
itholic
added a commit
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? This PR proposes to support `addArtifact(s)` for PySpark Cherry-pick #49572 for 4.0 ### Why are the changes needed? For feature parity with Spark Connect ### Does this PR introduce _any_ user-facing change? No API changes, but adding new API `addArtifact(s)` ### How was this patch tested? Added corresponding UTs with Spark Connect ### Was this patch authored or co-authored using generative AI tooling? No Closes #49583 from itholic/add_artifacts_4.0. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Haejoon Lee <haejoon.lee@databricks.com>
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 16, 2025
…t_artifact` ### What changes were proposed in this pull request? this test was added in #49572, but never enabled in ci ### Why are the changes needed? test coverage ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #50601 from zhengruifeng/add_missing_test_artifact. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? This PR proposes to support `addArtifact(s)` for PySpark Cherry-pick apache#49572 for 4.0 ### Why are the changes needed? For feature parity with Spark Connect ### Does this PR introduce _any_ user-facing change? No API changes, but adding new API `addArtifact(s)` ### How was this patch tested? Added corresponding UTs with Spark Connect ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49583 from itholic/add_artifacts_4.0. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Haejoon Lee <haejoon.lee@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to support
addArtifact(s)for PySparkWhy are the changes needed?
For feature parity with Spark Connect
Does this PR introduce any user-facing change?
No API changes, but adding new API
addArtifact(s)How was this patch tested?
Added corresponding UTs with Spark Connect
Was this patch authored or co-authored using generative AI tooling?
No