[SPARK-50902][CORE][K8S][TESTS] Add CRC32C test cases
#49582
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this PR, @yaooqinn ? |
yaooqinn
approved these changes
Jan 21, 2025
Member
yaooqinn
left a comment
yaooqinn
left a comment
There was a problem hiding this comment.
LGTM, thank you @dongjoon-hyun
Member
Author
|
Thank you, @yaooqinn ! |
Contributor
|
A failure occurred in https://github.com/dongjoon-hyun/spark/actions/runs/12881008656/job/35910916844 |
Member
Author
|
Thank you! Now all tests passed. Merged to master/4.0.
|
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 21, 2025
### What changes were proposed in this pull request? This PR aims to add `CRC32C` test cases. ### Why are the changes needed? Apache Spark supports `CRC32C`. We had better add more test coverage like `CRC32`. - #47929 ### Does this PR introduce _any_ user-facing change? No. This is a test case addition. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49582 from dongjoon-hyun/SPARK-50902. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 98f2767) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? This PR aims to add `CRC32C` test cases. ### Why are the changes needed? Apache Spark supports `CRC32C`. We had better add more test coverage like `CRC32`. - apache#47929 ### Does this PR introduce _any_ user-facing change? No. This is a test case addition. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49582 from dongjoon-hyun/SPARK-50902. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2233537) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
CRC32Ctest cases.Why are the changes needed?
Apache Spark supports
CRC32C. We had better add more test coverage likeCRC32.CRC32Cfor Shuffle Checksum #47929Does this PR introduce any user-facing change?
No. This is a test case addition.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.