[SPARK-50798][SQL][FOLLOWUP] Further improvements to NormalizePlan
#49585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 22, 2025
### What changes were proposed in this pull request? Improve `NormalizePlan` by fixing normalization of `InheritAnalysisRules` and add normalization for `CommonExpressionId` and expressions that use it. ### Why are the changes needed? PR #49460 mishandled normalization of `RuntimeReplaceable` because it copied original expression's tags to the replacement. This PR fixes that. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a test case to `NormalizePlanSuite`. ### Was this patch authored or co-authored using generative AI tooling? No Closes #49585 from mihailotim-db/mihailotim-db/normalize_plan_followup. Authored-by: Mihailo Timotic <mihailo.timotic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 09cb059) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
### What changes were proposed in this pull request? Improve `NormalizePlan` by fixing normalization of `InheritAnalysisRules` and add normalization for `CommonExpressionId` and expressions that use it. ### Why are the changes needed? PR apache#49460 mishandled normalization of `RuntimeReplaceable` because it copied original expression's tags to the replacement. This PR fixes that. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added a test case to `NormalizePlanSuite`. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49585 from mihailotim-db/mihailotim-db/normalize_plan_followup. Authored-by: Mihailo Timotic <mihailo.timotic@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit e9f1344) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve
NormalizePlanby fixing normalization ofInheritAnalysisRulesand add normalization forCommonExpressionIdand expressions that use it.Why are the changes needed?
PR #49460 mishandled normalization of
RuntimeReplaceablebecause it copied original expression's tags to the replacement. This PR fixes that.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case to
NormalizePlanSuite.Was this patch authored or co-authored using generative AI tooling?
No