Skip to content

Conversation

@wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Jan 22, 2025

What changes were proposed in this pull request?

This PR adds support for PCA and StringIndexer on Connect:

Why are the changes needed?

for feature parity

Does this PR introduce any user-facing change?

yes, new algorithms supported on connect

How was this patch tested?

The newly added tests pass

Was this patch authored or co-authored using generative AI tooling?

No

@wbo4958 wbo4958 changed the title [ML][PYTHON][CONNECT] Add support for StringIndexer/PCA on Connect [SPARK-50948][ML][PYTHON][CONNECT] Add support for StringIndexer/PCA on Connect Jan 22, 2025
@wbo4958 wbo4958 force-pushed the string_indexer_pca branch from 8ec01ee to f92ee76 Compare January 22, 2025 07:50
Copy link
Contributor

@zhengruifeng zhengruifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhengruifeng pushed a commit that referenced this pull request Jan 22, 2025
…on Connect

### What changes were proposed in this pull request?
This PR adds support for PCA and StringIndexer on Connect:

### Why are the changes needed?

for feature parity

### Does this PR introduce _any_ user-facing change?
yes, new algorithms supported on connect

### How was this patch tested?
The newly added tests pass

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #49600 from wbo4958/string_indexer_pca.

Authored-by: Bobby Wang <wbo4958@gmail.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 6658846)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
@zhengruifeng
Copy link
Contributor

merged to master/4.0

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
…on Connect

### What changes were proposed in this pull request?
This PR adds support for PCA and StringIndexer on Connect:

### Why are the changes needed?

for feature parity

### Does this PR introduce _any_ user-facing change?
yes, new algorithms supported on connect

### How was this patch tested?
The newly added tests pass

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#49600 from wbo4958/string_indexer_pca.

Authored-by: Bobby Wang <wbo4958@gmail.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
(cherry picked from commit 248687a)
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants