Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Jan 23, 2025

What changes were proposed in this pull request?

This PR proposes to add InvalidPlanInput to Spark Connect Python client.

Why are the changes needed?

To keep the consistency with Spark Connect Scala client. We should capture the SparkConnectGrpcException more generally across all clients.

Does this PR introduce any user-facing change?

No API changes, but the user-facing error message would keep consistency with Spark Connect Scala client.

How was this patch tested?

Updated the existing UT.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member

Merged to master and branch-4.0.

HyukjinKwon pushed a commit that referenced this pull request Feb 13, 2025
…t Python client

### What changes were proposed in this pull request?

This PR proposes to add `InvalidPlanInput` to Spark Connect Python client.

### Why are the changes needed?

To keep the consistency with Spark Connect Scala client. We should capture the `SparkConnectGrpcException` more generally across all clients.

### Does this PR introduce _any_ user-facing change?

No API changes, but the user-facing error message would keep consistency with Spark Connect Scala client.

### How was this patch tested?

Updated the existing UT.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49616 from itholic/invalid_input.

Authored-by: Haejoon Lee <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit f749742)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
…t Python client

### What changes were proposed in this pull request?

This PR proposes to add `InvalidPlanInput` to Spark Connect Python client.

### Why are the changes needed?

To keep the consistency with Spark Connect Scala client. We should capture the `SparkConnectGrpcException` more generally across all clients.

### Does this PR introduce _any_ user-facing change?

No API changes, but the user-facing error message would keep consistency with Spark Connect Scala client.

### How was this patch tested?

Updated the existing UT.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49616 from itholic/invalid_input.

Authored-by: Haejoon Lee <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit f4d0e12)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants