[SPARK-51022][SQL] Remove unused tableSampleClause in build() method of MsSqlServerSQLQueryBuilder and DB2SQLQueryBuilder#49714
Closed
wayneguow wants to merge 2 commits into
Closed
Conversation
Member
|
cc @beliefer |
wayneguow
changed the title
tableSampleClause in build() method of MsSqlServerSQLQueryBuilder and DB2SQLBuildertableSampleClause in build() method of MsSqlServerSQLQueryBuilder and DB2SQLQueryBuilder
beliefer
pushed a commit
that referenced
this pull request
Jan 29, 2025
…hod of `MsSqlServerSQLQueryBuilder` and `DB2SQLQueryBuilder` ### What changes were proposed in this pull request? This PR aims to remove unused `tableSampleClause` in `build()` method of `MsSqlServerSQLQueryBuilder` and `DB2SQLBuilder`. From the discussion here: #49711 (comment) ### Why are the changes needed? Currently, `MsSqlServerDialect` and `DB2Dialect` don't support `tableSample` (default value of `supportsTableSample` is `false`), so `tableSampleClause` is unnecessary when building sql in the `build()` method. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated a related test case and passed GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49714 from wayneguow/jdbc_tablesample. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: beliefer <beliefer@163.com> (cherry picked from commit 840f74a) Signed-off-by: beliefer <beliefer@163.com>
Contributor
|
Merged into master/branch-4.0 Thank you all! @wayneguow @dongjoon-hyun |
Member
|
Thank you, @wayneguow and @beliefer . |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…hod of `MsSqlServerSQLQueryBuilder` and `DB2SQLQueryBuilder` ### What changes were proposed in this pull request? This PR aims to remove unused `tableSampleClause` in `build()` method of `MsSqlServerSQLQueryBuilder` and `DB2SQLBuilder`. From the discussion here: apache#49711 (comment) ### Why are the changes needed? Currently, `MsSqlServerDialect` and `DB2Dialect` don't support `tableSample` (default value of `supportsTableSample` is `false`), so `tableSampleClause` is unnecessary when building sql in the `build()` method. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Updated a related test case and passed GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49714 from wayneguow/jdbc_tablesample. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: beliefer <beliefer@163.com> (cherry picked from commit ba0ec11) Signed-off-by: beliefer <beliefer@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove unused
tableSampleClauseinbuild()method ofMsSqlServerSQLQueryBuilderandDB2SQLBuilder.From the discussion here: #49711 (comment)
Why are the changes needed?
Currently,
MsSqlServerDialectandDB2Dialectdon't supporttableSample(default value ofsupportsTableSampleisfalse), sotableSampleClauseis unnecessary when building sql in thebuild()method.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Updated a related test case and passed GA.
Was this patch authored or co-authored using generative AI tooling?
No.