[SPARK-51047][SS][TESTS] Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals #49747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dinals as well as non-ascending ordinals
anishshri-db
changed the title
Contributor
Author
|
cc - @HeartSaVioR - PTAL, thx ! |
HeartSaVioR
reviewed
Jan 31, 2025
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
Looks good in overall. Only nits.
...e/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala
Outdated
Show resolved
Hide resolved
...e/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala
Outdated
Show resolved
Hide resolved
...e/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala
Outdated
Show resolved
Hide resolved
...e/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala
Show resolved
Hide resolved
...e/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreSuite.scala
Outdated
Show resolved
Hide resolved
HeartSaVioR
changed the title
Contributor
|
Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Feb 1, 2025
…ro start ordinals as well as non-ascending ordinals ### What changes were proposed in this pull request? Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals ### Why are the changes needed? Improve coverage in this area ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change ``` [info] Run completed in 8 minutes, 33 seconds. [info] Total number of tests run: 1032 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 1032, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes #49747 from anishshri-db/task/SPARK-51047. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 5cd25fc) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ro start ordinals as well as non-ascending ordinals ### What changes were proposed in this pull request? Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals ### Why are the changes needed? Improve coverage in this area ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Test only change ``` [info] Run completed in 8 minutes, 33 seconds. [info] Total number of tests run: 1032 [info] Suites: completed 1, aborted 0 [info] Tests: succeeded 1032, failed 0, canceled 0, ignored 0, pending 0 [info] All tests passed. ``` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49747 from anishshri-db/task/SPARK-51047. Authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 48075c3) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add tests to verify scan ordering for non-zero start ordinals as well as non-ascending ordinals
Why are the changes needed?
Improve coverage in this area
Does this PR introduce any user-facing change?
No
How was this patch tested?
Test only change
Was this patch authored or co-authored using generative AI tooling?
No