[SPARK-51055][SS][CONNECT] Streaming foreachBatch should call init logic inside a try#49757
Closed
WweiL wants to merge 6 commits intoapache:masterfrom
Closed
[SPARK-51055][SS][CONNECT] Streaming foreachBatch should call init logic inside a try#49757WweiL wants to merge 6 commits intoapache:masterfrom
WweiL wants to merge 6 commits intoapache:masterfrom
Conversation
grundprinzip
approved these changes
Feb 1, 2025
Contributor
|
@WweiL Would you mind looking at the CI build? The failure seems to be relevant. |
Contributor
Author
|
@HeartSaVioR Yes it indeed looks relevant, I'll take a look, thanks! |
jiateoh
approved these changes
Feb 3, 2025
Contributor
jiateoh
left a comment
jiateoh
left a comment
There was a problem hiding this comment.
LGTM after the build fix, thanks!
HyukjinKwon
approved these changes
Feb 4, 2025
Contributor
Author
|
@HyukjinKwon can we merge this : ) TY! |
Member
|
Merged to master and branch-4.0. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 4, 2025
…gic inside a try ### What changes were proposed in this pull request? So that any error can be propagated to the jvm. Especially the python version issue. `handle_worker_exception` would write out a special int to the jvm, and wil be caught here: https://github.com/apache/spark/blob/c92021091502b15b6020e6e4cc9b148009450ba5/core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala#L99-L103 ### Why are the changes needed? Spark Connect improvements ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes #49757 from WweiL/feb-worker-init-error-propagate. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 505c644) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…gic inside a try ### What changes were proposed in this pull request? So that any error can be propagated to the jvm. Especially the python version issue. `handle_worker_exception` would write out a special int to the jvm, and wil be caught here: https://github.com/apache/spark/blob/cd1f1b3b1884c165b077120820706b1816e111d8/core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala#L99-L103 ### Why are the changes needed? Spark Connect improvements ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49757 from WweiL/feb-worker-init-error-propagate. Authored-by: Wei Liu <wei.liu@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit ec0931d) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
So that any error can be propagated to the jvm. Especially the python version issue.
handle_worker_exceptionwould write out a special int to the jvm, and wil be caught here:spark/core/src/main/scala/org/apache/spark/api/python/StreamingPythonRunner.scala
Lines 99 to 103 in c920210
Why are the changes needed?
Spark Connect improvements
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit test
Was this patch authored or co-authored using generative AI tooling?
No