[SPARK-51056][PYTHON] Avoid unnecessary object creation in SparkSession.getActiveSession.#49758
Closed
ueshin wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-51056][PYTHON] Avoid unnecessary object creation in SparkSession.getActiveSession.#49758ueshin wants to merge 2 commits intoapache:masterfrom
ueshin wants to merge 2 commits intoapache:masterfrom
Conversation
dongjoon-hyun
approved these changes
Feb 1, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, this optimization looks reasonable to me, too. Thank you, @ueshin .
(Pending CIs).
Member
Author
|
The remaining tests are not related to this PR. |
Member
Author
|
Thanks! merging to master/4.0. |
ueshin
added a commit
that referenced
this pull request
Feb 1, 2025
…on.getActiveSession ### What changes were proposed in this pull request? Avoids unnecessary object creation in `SparkSession.getActiveSession`. ### Why are the changes needed? `SparkSession.getActiveSession` tries to create a new `SparkSession` instance, but the instance will not be used in many cases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49758 from ueshin/issues/SPARK-51056/getactivesession. Lead-authored-by: Takuya Ueshin <ueshin@databricks.com> Co-authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Takuya Ueshin <ueshin@databricks.com> (cherry picked from commit e1c8b4d) Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…on.getActiveSession ### What changes were proposed in this pull request? Avoids unnecessary object creation in `SparkSession.getActiveSession`. ### Why are the changes needed? `SparkSession.getActiveSession` tries to create a new `SparkSession` instance, but the instance will not be used in many cases. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests should pass. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49758 from ueshin/issues/SPARK-51056/getactivesession. Lead-authored-by: Takuya Ueshin <ueshin@databricks.com> Co-authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Takuya Ueshin <ueshin@databricks.com> (cherry picked from commit 2c8562c) Signed-off-by: Takuya Ueshin <ueshin@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoids unnecessary object creation in
SparkSession.getActiveSession.Why are the changes needed?
SparkSession.getActiveSessiontries to create a newSparkSessioninstance, but the instance will not be used in many cases.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing tests should pass.
Was this patch authored or co-authored using generative AI tooling?
No.