[SPARK-51101][ML][PYTHON][CONNECT][TESTS] Add doctest for pyspark.ml.connect.functions#49821
Closed
zhengruifeng wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-51101][ML][PYTHON][CONNECT][TESTS] Add doctest for pyspark.ml.connect.functions#49821zhengruifeng wants to merge 5 commits intoapache:masterfrom
pyspark.ml.connect.functions#49821zhengruifeng wants to merge 5 commits intoapache:masterfrom
Conversation
zhengruifeng
commented
Feb 6, 2025
Contributor
Author
There was a problem hiding this comment.
@HyukjinKwon I want to test the doctest of predict_batch_udf in connect mode, it seems I have to add a dummy function here. Is there some elegant way to do this?
Member
There was a problem hiding this comment.
I think we can just have a function predict_batch_udf that calls PyMLFunctions.predict_batch_udf
zhengruifeng
force-pushed
the
ml_connect_function_doc_tests
branch
from
957e9fa to
17cd70f
Compare
Contributor
Author
|
cc @HyukjinKwon would you mind taking another look? |
xinrong-meng
approved these changes
Feb 7, 2025
Member
|
LGTM thank you! |
zhengruifeng
added a commit
that referenced
this pull request
Feb 7, 2025
….connect.functions` ### What changes were proposed in this pull request? Add doctest for `pyspark.ml.connect.functions` ### Why are the changes needed? to improve the test coverage ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #49821 from zhengruifeng/ml_connect_function_doc_tests. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 935c2b0) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
Author
|
thanks @xinrong-meng and @HyukjinKwon merged to master |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
….connect.functions` ### What changes were proposed in this pull request? Add doctest for `pyspark.ml.connect.functions` ### Why are the changes needed? to improve the test coverage ### Does this PR introduce _any_ user-facing change? no, test-only ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#49821 from zhengruifeng/ml_connect_function_doc_tests. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 9d1b69d) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add doctest for
pyspark.ml.connect.functionsWhy are the changes needed?
to improve the test coverage
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no