[SPARK-51147][SS] Refactor streaming related classes to a dedicated streaming directory#49867
Closed
bogao007 wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-51147][SS] Refactor streaming related classes to a dedicated streaming directory#49867bogao007 wants to merge 3 commits intoapache:masterfrom
bogao007 wants to merge 3 commits intoapache:masterfrom
Conversation
HyukjinKwon
approved these changes
Feb 11, 2025
| currentId | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Can we remove this ? we need newline at end of file right ?
anishshri-db
approved these changes
Feb 11, 2025
HeartSaVioR
approved these changes
Feb 11, 2025
Contributor
There was a problem hiding this comment.
+1 pending CI.
We had talked about the removal of line for end of file, and according to him, there is extra line in @bogao007 's local change - let's see whether this is GH UI issue or CI will also complain.
Contributor
|
Thanks! Merging to master/4.0. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Feb 11, 2025
…treaming directory ### What changes were proposed in this pull request? Refactor streaming classes under `sql/core/src/main/scala/org/apache/spark/sql/execution/python` to `sql/core/src/main/scala/org/apache/spark/sql/execution/python/streaming`. ### Why are the changes needed? Better organization for streaming related code base. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49867 from bogao007/streaming-python-dir. Authored-by: bogao007 <bo.gao@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 394458f) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…treaming directory ### What changes were proposed in this pull request? Refactor streaming classes under `sql/core/src/main/scala/org/apache/spark/sql/execution/python` to `sql/core/src/main/scala/org/apache/spark/sql/execution/python/streaming`. ### Why are the changes needed? Better organization for streaming related code base. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49867 from bogao007/streaming-python-dir. Authored-by: bogao007 <bo.gao@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 17af67d) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor streaming classes under
sql/core/src/main/scala/org/apache/spark/sql/execution/pythontosql/core/src/main/scala/org/apache/spark/sql/execution/python/streaming.Why are the changes needed?
Better organization for streaming related code base.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.