[MINOR][DOCS] Fix incorrect description of constraint on spark.sql.adaptive.coalescePartitions.minPartitionSize#49872
Closed
JoshRosen wants to merge 1 commit into
Conversation
Contributor
|
thanks, merging to master/4.0/3.5 |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 11, 2025
…aptive.coalescePartitions.minPartitionSize ### What changes were proposed in this pull request? This PR addresses a minor problem in the SQL performance guide's description of the `spark.sql.adaptive.coalescePartitions.minPartitionSize` configuration. Currently, the guide says: > The minimum size of shuffle partitions after coalescing. Its value can be at most 20% of `spark.sql.adaptive.advisoryPartitionSizeInBytes`. This is useful when the target size is ignored during partition coalescing, which is the default case. but the second sentence is not true because the 20% limitation was removed in #33655 (comment) (SPARK-36430), which shipped in 3.2.0. That PR updated the in-code description but not the guide on the web. ### Why are the changes needed? Incorrect doc is misleading. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? n/a ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49872 from JoshRosen/fix-spark.sql.adaptive.coalescePartitions.minPartitionSize-doc. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit e7ceb5b) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
cloud-fan
pushed a commit
that referenced
this pull request
Feb 11, 2025
…aptive.coalescePartitions.minPartitionSize ### What changes were proposed in this pull request? This PR addresses a minor problem in the SQL performance guide's description of the `spark.sql.adaptive.coalescePartitions.minPartitionSize` configuration. Currently, the guide says: > The minimum size of shuffle partitions after coalescing. Its value can be at most 20% of `spark.sql.adaptive.advisoryPartitionSizeInBytes`. This is useful when the target size is ignored during partition coalescing, which is the default case. but the second sentence is not true because the 20% limitation was removed in #33655 (comment) (SPARK-36430), which shipped in 3.2.0. That PR updated the in-code description but not the guide on the web. ### Why are the changes needed? Incorrect doc is misleading. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? n/a ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49872 from JoshRosen/fix-spark.sql.adaptive.coalescePartitions.minPartitionSize-doc. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit e7ceb5b) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…aptive.coalescePartitions.minPartitionSize ### What changes were proposed in this pull request? This PR addresses a minor problem in the SQL performance guide's description of the `spark.sql.adaptive.coalescePartitions.minPartitionSize` configuration. Currently, the guide says: > The minimum size of shuffle partitions after coalescing. Its value can be at most 20% of `spark.sql.adaptive.advisoryPartitionSizeInBytes`. This is useful when the target size is ignored during partition coalescing, which is the default case. but the second sentence is not true because the 20% limitation was removed in apache#33655 (comment) (SPARK-36430), which shipped in 3.2.0. That PR updated the in-code description but not the guide on the web. ### Why are the changes needed? Incorrect doc is misleading. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? n/a ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49872 from JoshRosen/fix-spark.sql.adaptive.coalescePartitions.minPartitionSize-doc. Authored-by: Josh Rosen <joshrosen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 06a11f3) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR addresses a minor problem in the SQL performance guide's description of the
spark.sql.adaptive.coalescePartitions.minPartitionSizeconfiguration.Currently, the guide says:
but the second sentence is not true because the 20% limitation was removed in #33655 (comment) (SPARK-36430), which shipped in 3.2.0. That PR updated the in-code description but not the guide on the web.
Why are the changes needed?
Incorrect doc is misleading.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
n/a
Was this patch authored or co-authored using generative AI tooling?
No.