[SPARK-51157][SQL][3.5] Add missing @VarArgs Scala annotation for Scala function APIs#49906
Closed
yaooqinn wants to merge 2 commits intoapache:branch-3.5from
Closed
[SPARK-51157][SQL][3.5] Add missing @VarArgs Scala annotation for Scala function APIs#49906yaooqinn wants to merge 2 commits intoapache:branch-3.5from
yaooqinn wants to merge 2 commits intoapache:branch-3.5from
Conversation
…la function APIs
…la function APIs
Member
Author
|
cc @dongjoon-hyun, and thanks for reminding |
dongjoon-hyun
approved these changes
Feb 12, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @yaooqinn .
Merged to branch-3.5.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 12, 2025
…la function APIs ### What changes were proposed in this pull request? This PR adds missing `varargs` Scala annotation for Scala function APIs ### Why are the changes needed? To instruct the compiler to generate java varargs-style forwarder methods for interop ### Does this PR introduce _any_ user-facing change? No, do not change the current behavior. ### How was this patch tested? w/o `varargs`:  ### Was this patch authored or co-authored using generative AI tooling? no Closes #49906 from yaooqinn/SPARK-51157-35. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds missing
@varargsScala annotation for Scala function APIsWhy are the changes needed?
To instruct the compiler to generate java varargs-style forwarder methods for interop
Does this PR introduce any user-facing change?
No, do not change the current behavior.
How was this patch tested?
w/o
@varargs:Was this patch authored or co-authored using generative AI tooling?
no