[SPARK-51239][INFRA] Upgrade Github Action image for TPCDSQueryBenchmark from 20.04 to latest#49980
Closed
wayneguow wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-51239][INFRA] Upgrade Github Action image for TPCDSQueryBenchmark from 20.04 to latest#49980wayneguow wants to merge 3 commits intoapache:masterfrom
TPCDSQueryBenchmark from 20.04 to latest#49980wayneguow wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
If this PR works, it needs to be applied to all active branches. |
LuciferYang
reviewed
Feb 17, 2025
.github/workflows/benchmark.yml
Outdated
| name: "Generate an input dataset for TPCDSQueryBenchmark with SF=1" | ||
| if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, '*') | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-24.04 |
Contributor
There was a problem hiding this comment.
Can you manually run a org.apache.spark.sql.execution.benchmark.TPCDSQueryBenchmark to ensure that this modification is okay?
Contributor
Author
There was a problem hiding this comment.
Sure. Waiting for:
wayneguow
commented
Feb 17, 2025
.github/workflows/benchmark.yml
Outdated
| name: "Generate an input dataset for TPCDSQueryBenchmark with SF=1" | ||
| if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, '*') | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-24.04 |
Contributor
Author
There was a problem hiding this comment.
In order to avoid uncertain compatibility in the future, I am using 24.04 here instead of latest.
LuciferYang
reviewed
Feb 17, 2025
.github/workflows/build_and_test.yml
Outdated
| # Pin to 'Ubuntu 20.04' due to 'databricks/tpcds-kit' compilation | ||
| runs-on: ubuntu-20.04 | ||
| # Pin to 'Ubuntu 24.04' due to 'databricks/tpcds-kit' compilation | ||
| runs-on: ubuntu-24.04 |
Contributor
There was a problem hiding this comment.
can we just use ubuntu-latest as others
Contributor
Author
|
|
LuciferYang
reviewed
Feb 17, 2025
LuciferYang
approved these changes
Feb 17, 2025
beliefer
approved these changes
Feb 17, 2025
wayneguow
changed the title
TPCDSQueryBenchmark from 20.04 to 24.04TPCDSQueryBenchmark from 20.04 to latest
HyukjinKwon
approved these changes
Feb 18, 2025
LuciferYang
pushed a commit
that referenced
this pull request
Feb 19, 2025
…mark` from 20.04 to latest ### What changes were proposed in this pull request? This PR aims to upgrade Github Action image for `TPCDSQueryBenchmark` from 20.04 to latest and update the dependency of `databricks/tpcds-kit` to the latest codes. In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7 ### Why are the changes needed? Refer to: actions/runner-images#11101 > The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual check on Ubuntu 24.04 and Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49980 from wayneguow/tpcds_inf. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit 0af25b8) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Contributor
|
Merged into master and branch-4.0. Thanks @wayneguow @HyukjinKwon and @beliefer |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 21, 2025
…tu-20.04` to `ubuntu-22.04` and solved the `TPCDSQueryBenchmark` compatibility issue ### What changes were proposed in this pull request? This PR aims to upgrade left Github Action image from `ubuntu-20.04`to `ubuntu-22.04` and solved the `TPCDSQueryBenchmark` compatibility issue. ### Why are the changes needed? Same to #49980 , since ubuntu 20.04 will be removed, and according to `Maintenance releases and EOL` at https://spark.apache.org/versioning-policy.html, Spark 3.5 will still be in service before April 12th 2026, so we also need to make this change in branch-3.5. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49988 from wayneguow/branch-3.5. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…mark` from 20.04 to latest ### What changes were proposed in this pull request? This PR aims to upgrade Github Action image for `TPCDSQueryBenchmark` from 20.04 to latest and update the dependency of `databricks/tpcds-kit` to the latest codes. In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7 ### Why are the changes needed? Refer to: actions/runner-images#11101 > The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01  ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual check on Ubuntu 24.04 and Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#49980 from wayneguow/tpcds_inf. Authored-by: Wei Guo <guow93@gmail.com> Signed-off-by: yangjie01 <yangjie01@baidu.com> (cherry picked from commit dbaa8d7) Signed-off-by: yangjie01 <yangjie01@baidu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade Github Action image for
TPCDSQueryBenchmarkfrom 20.04 to latest and update the dependency ofdatabricks/tpcds-kitto the latest codes.In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7
Why are the changes needed?
Refer to: actions/runner-images#11101
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual check on Ubuntu 24.04 and Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.