Skip to content

Conversation

@beliefer
Copy link
Contributor

What changes were proposed in this pull request?

This PR proposes to add test cases for LZ4 and SNAPPY for text.

Why are the changes needed?

Currently, Spark missing the test cases for LZ4 and SNAPPY.

Does this PR introduce any user-facing change?

'No'.
Add test.

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

'No'.

@github-actions github-actions bot added the SQL label Feb 21, 2025
@beliefer
Copy link
Contributor Author

ping @dongjoon-hyun @LuciferYang

@LuciferYang LuciferYang changed the title [SPARK-51283][SQL] Add test cases for LZ4 and SNAPPY for text [SPARK-51283][SQL][TESTS] Add test cases for LZ4 and SNAPPY for text Feb 21, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dongjoon-hyun pushed a commit that referenced this pull request Feb 21, 2025
### What changes were proposed in this pull request?
This PR proposes to add test cases for `LZ4` and `SNAPPY` for text.

### Why are the changes needed?
Currently, Spark missing the test cases for `LZ4` and `SNAPPY`.

### Does this PR introduce _any_ user-facing change?
'No'.
Add test.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
'No'.

Closes #50043 from beliefer/SPARK-51283.

Authored-by: beliefer <beliefer@163.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 140a69b)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Thank you, @beliefer and @LuciferYang .
Merged to master/4.0.

@beliefer
Copy link
Contributor Author

@dongjoon-hyun @LuciferYang Thank you!

zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 14, 2025
### What changes were proposed in this pull request?
This PR proposes to add test cases for `LZ4` and `SNAPPY` for text.

### Why are the changes needed?
Currently, Spark missing the test cases for `LZ4` and `SNAPPY`.

### Does this PR introduce _any_ user-facing change?
'No'.
Add test.

### How was this patch tested?
GA.

### Was this patch authored or co-authored using generative AI tooling?
'No'.

Closes apache#50043 from beliefer/SPARK-51283.

Authored-by: beliefer <beliefer@163.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 89530d2)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants