[SPARK-51292][SQL] Remove unnecessary inheritance from PlanTestBase, ExpressionEvalHelper and PlanTest #50047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExpressionEvalHelper and PlanTest
Contributor
Author
|
ping @LuciferYang cc @cloud-fan |
LuciferYang
approved these changes
Feb 23, 2025
beliefer
added a commit
that referenced
this pull request
Feb 23, 2025
…ExpressionEvalHelper and PlanTest
### What changes were proposed in this pull request?
This PR proposes to remove unnecessary inheritance from `PlanTestBase`, `ExpressionEvalHelper` and `PlanTest`.
### Why are the changes needed?
1. Some class extends both `ExpressionEvalHelper` and `PlanTestBase`, but `ExpressionEvalHelper` already extends `PlanTestBase`.
```
trait ExpressionEvalHelper extends ScalaCheckDrivenPropertyChecks with PlanTestBase {
self: SparkFunSuite =>
...
}
```
2. Class `NullDownPropagationSuite`, `OptimizeCsvExprsSuite`, `PushFoldableIntoBranchesSuite` doesn't need `ExpressionEvalHelper` at all.
3. Some class extends both `QueryTest` and `PlanTest`, but `QueryTest` already extends `PlanTest`.
```
abstract class QueryTest extends PlanTest {
...
}
```
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner code.
### How was this patch tested?
GA.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
Closes #50047 from beliefer/SPARK-51292.
Authored-by: beliefer <beliefer@163.com>
Signed-off-by: beliefer <beliefer@163.com>
(cherry picked from commit 3027968)
Signed-off-by: beliefer <beliefer@163.com>
Contributor
Author
|
Merged into branch-4.0/master |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…ExpressionEvalHelper and PlanTest
### What changes were proposed in this pull request?
This PR proposes to remove unnecessary inheritance from `PlanTestBase`, `ExpressionEvalHelper` and `PlanTest`.
### Why are the changes needed?
1. Some class extends both `ExpressionEvalHelper` and `PlanTestBase`, but `ExpressionEvalHelper` already extends `PlanTestBase`.
```
trait ExpressionEvalHelper extends ScalaCheckDrivenPropertyChecks with PlanTestBase {
self: SparkFunSuite =>
...
}
```
2. Class `NullDownPropagationSuite`, `OptimizeCsvExprsSuite`, `PushFoldableIntoBranchesSuite` doesn't need `ExpressionEvalHelper` at all.
3. Some class extends both `QueryTest` and `PlanTest`, but `QueryTest` already extends `PlanTest`.
```
abstract class QueryTest extends PlanTest {
...
}
```
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner code.
### How was this patch tested?
GA.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
Closes apache#50047 from beliefer/SPARK-51292.
Authored-by: beliefer <beliefer@163.com>
Signed-off-by: beliefer <beliefer@163.com>
(cherry picked from commit b107b11)
Signed-off-by: beliefer <beliefer@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to remove unnecessary inheritance from
PlanTestBase,ExpressionEvalHelperandPlanTest.Why are the changes needed?
ExpressionEvalHelperandPlanTestBase, butExpressionEvalHelperalready extendsPlanTestBase.NullDownPropagationSuite,OptimizeCsvExprsSuite,PushFoldableIntoBranchesSuitedoesn't needExpressionEvalHelperat all.QueryTestandPlanTest, butQueryTestalready extendsPlanTest.Does this PR introduce any user-facing change?
'No'.
Just update the inner code.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.