Skip to content

Conversation

@drexler-sky
Copy link
Contributor

What changes were proposed in this pull request?

deprecate the following legacy APIs in Catalog

  • listColumns(dbName: String, tableName: String)
  • getTable(dbName: String, tableName: String)
  • getFunction(dbName: String, functionName: String)
  • tableExists(dbName: String, tableName: String)
  • functionExists(dbName: String, functionName: String)

Why are the changes needed?

Deprecate the legacy APIs in favor of the new ones that accept qualified table names.

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

existing tests

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the SQL label Feb 26, 2025
@cloud-fan
Copy link
Contributor

I'm fine with it, cc @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pinging me, @cloud-fan .

cc @huaxingao too.

@dongjoon-hyun
Copy link
Member

Also, cc @yaooqinn and @LuciferYang , too

LuciferYang
LuciferYang previously approved these changes Mar 12, 2025
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang LuciferYang dismissed their stale review March 12, 2025 02:17

The change is fine, but the Jira ID seems to be incorrect. Could you please double-check it?

@LuciferYang
Copy link
Contributor

image

@beliefer
Copy link
Contributor

These API looks not used anymore! +1 for this change.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 2b12416 Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants