[SPARK-51280][CONNECT] Improve RESPONSE_ALREADY_RECEIVED error class #50091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-sakthi
reviewed
Feb 26, 2025
Member
|
LGTM (barring the builds pass) :) |
HyukjinKwon
approved these changes
Mar 16, 2025
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Let RESPONSE_ALREADY_RECEIVED contain the origin of the error: either OPERATION_NOT_FOUND or SESSION_NOT_FOUND.
Why are the changes needed?
The error message of RESPONSE_ALREADY_RECEIVED only implies OPERATION_NOT_FOUND while the error can also be raised when SESSION_NOT_FOUND is thrown.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.