[SPARK-51337][SQL] Add maxRows to CTERelationDef and CTERelationRef #50104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-max-rows-field-to-cte-relation-ref
branch
from
3b1bb8c to
c77e7fe
Compare
vladimirg-db
changed the title
vladimirg-db
force-pushed
the
vladimir-golubev_data/add-max-rows-field-to-cte-relation-ref
branch
from
c77e7fe to
463c1a9
Compare
cloud-fan
approved these changes
Feb 28, 2025
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
maxRowsfield toCTERelationRef.Why are the changes needed?
The Analyzer validates scalar subqueries by checking if it outputs just one row or not: https://github.com/vladimirg-db/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ValidateSubqueryExpression.scala#L144.
This works in fixed-point Analyzer, because CTEs are inlined before
CheckAnalysis. However, in single-pass Analyzer, we validate the subquery right after its validation, soCTERelationRefmust output correctmaxRowsas well, based on the relatedCTERelationDef'smaxRows.Does this PR introduce any user-facing change?
There should be no changes to existing Catalyst behavior.
Added a flag to mitigate the potential edge-cases:
spark.sql.cteRelationDefMaxRows.enabled.How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.