[SPARK-51446][SQL] Improve the codecNameMap for the compression codec#50221
Closed
beliefer wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-51446][SQL] Improve the codecNameMap for the compression codec#50221beliefer wants to merge 1 commit intoapache:masterfrom
beliefer wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
LuciferYang
reviewed
Mar 10, 2025
Contributor
There was a problem hiding this comment.
private static final EnumMap<HadoopCompressionCodec, String> codecNameMap = new EnumMap<>(
Arrays.stream(HadoopCompressionCodec.values())
.collect(Collectors.toMap(
Function.identity(),
codec -> codec.name().toLowerCase(Locale.ROOT)
))
);Does it look better this way?
Contributor
Author
There was a problem hiding this comment.
It brings extra transform from java.util.Map to EnumMap. How about ?
private static final EnumMap<HadoopCompressionCodec, String> codecNameMap =
Arrays.stream(HadoopCompressionCodec.values()).collect(
Collectors.toMap(
codec -> codec,
codec -> codec.name().toLowerCase(Locale.ROOT),
(oldValue, newValue) -> oldValue,
() -> new EnumMap<>(HadoopCompressionCodec.class)));
LuciferYang
approved these changes
Mar 10, 2025
Contributor
Author
|
Merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to improve the
codecNameMapfor the [hadoop|avro|orc|parquet] compression codecs.Why are the changes needed?
Currently, [hadoop|avro|orc|parquet] compression codecs select java.util.Map to store the mapping between compression codec to the short name.
Enum Map has the following advantages.
High performance: Due to the limited number of enumeration values, Enum Map uses arrays internally to store data, with an access speed close to O (1).
Low memory usage: Enum Map only stores key value pairs of enumeration values, without the need for a hash table structure, resulting in smaller memory usage.
Orderliness: The Enum Map maintains key value pairs in the order defined by the enumeration, making it suitable for scenarios that require ordered traversal.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No