[SPARK-51494][BUILD] Upgrade to Apache parent pom 33 #50261
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? Spark currently uses Apache parent pom 18. This is a proposed upgrade to the latest version, which is 33. ### Why are the changes needed? Spark has not updated the parent pom since [SPARK-22511](https://issues.apache.org/jira/browse/SPARK-22511) 8 years ago. The full delta is visible here: apache/maven-apache-parent@apache-18...apache-33 Summary of notable changes: * [MPOM-118](https://issues.apache.org/jira/browse/MPOM-118): Enforce strong GPG signatures by default * [MPOM-225](https://issues.apache.org/jira/browse/MPOM-225): add ASF snapshots repository to pluginRepositories * [MPOM-260](https://issues.apache.org/jira/browse/MPOM-260): Configure Maven Javadoc Plugin for more reproducible builds * [MPOM-287](https://issues.apache.org/jira/browse/MPOM-287): Disable m2e warning for m-remote-resource-p * [MPOM-378](https://issues.apache.org/jira/browse/MPOM-378): Using an SPDX identifier as the license name is recommended by Maven * [MPOM-486](https://issues.apache.org/jira/browse/MPOM-486): Enable autoVersionSubmodules for maven-release-plugin * Version management and upgrades for various Maven plugins. For the most part, Spark was already managing these plugins to versions equal to or greater than the parent pom. The one exception is maven-jar-plugin, which I've upgraded to match the parent. ### Does this PR introduce _any_ user-facing change? No, this does not introduce changes to user-facing Spark functionality. Version updates will be visible to developers. ### How was this patch tested? Local `mvn` build with the new parent pom succeeds. I also verified elapsed time for a full build is approximately the same before and after, because maven-jar-plugin has occasionally had performance regressions in the past. ### Was this patch authored or co-authored using generative AI tooling? No.
dongjoon-hyun
approved these changes
Mar 13, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @cnauroth .
Merged to master for Apache Spark 4.1.0.
Contributor
Author
|
I appreciate it. Thank you, @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark currently uses Apache parent pom 18. This is a proposed upgrade to the latest version, which is 33.
Why are the changes needed?
Spark has not updated the parent pom since SPARK-22511 8 years ago. The full delta is visible here:
apache/maven-apache-parent@apache-18...apache-33
Summary of notable changes:
Does this PR introduce any user-facing change?
No, this does not introduce changes to user-facing Spark functionality. Version updates will be visible to developers.
How was this patch tested?
Local
mvnbuild with the new parent pom succeeds. I also verified elapsed time for a full build is approximately the same before and after, because maven-jar-plugin has occasionally had performance regressions in the past.Was this patch authored or co-authored using generative AI tooling?
No.