Skip to content

[SPARK-51496][SQL] CaseInsensitiveStringMap comparison should ignore case #50275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huaxingao wants to merge 3 commits into from
Closed

[SPARK-51496][SQL] CaseInsensitiveStringMap comparison should ignore case #50275

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d78c35
[SPARK-51496][SQL] CaseInsensitiveStringMap comparison should ignore …
huaxingao Mar 13, 2025
094bb05
only change key to lower case
huaxingao Mar 16, 2025
03e6937
address comments
huaxingao Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2Writes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ object V2Writes extends Rule[LogicalPlan] with PredicateHelper {

override def apply(plan: LogicalPlan): LogicalPlan = plan transformDown {
case a @ AppendData(r: DataSourceV2Relation, query, options, _, None, _) =>
val writeOptions = mergeOptions(options, r.options.asScala.toMap)
val writeOptions = mergeOptions(options, r.options.asCaseSensitiveMap.asScala.toMap)
Copy link
Contributor

@cloud-fan cloud-fan Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we do the same for other write commands? @huaxingao

Copy link
Contributor Author

@huaxingao huaxingao Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a follow-up PR for this.

val writeBuilder = newWriteBuilder(r.table, writeOptions, query.schema)
val write = writeBuilder.build()
val newQuery = DistributionAndOrderingUtils.prepareQuery(write, query, r.funCatalog)
Expand Down