[SPARK-51602][SQL] Regenerate AttributeReferences to Aliases with collated expression trees #50388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
force-pushed
the
vladimir-golubev_data/regenerate-attribute-references-to-aliases-in-collated-expression-subtrees-as-well
branch
from
cef0422 to
3056ba2
Compare
vladimirg-db
force-pushed
the
vladimir-golubev_data/regenerate-attribute-references-to-aliases-in-collated-expression-subtrees-as-well
branch
2 times, most recently
from
ea326a7 to
065db10
Compare
vladimirg-db
force-pushed
the
vladimir-golubev_data/regenerate-attribute-references-to-aliases-in-collated-expression-subtrees-as-well
branch
from
065db10 to
b82a7e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Regenerate AttributeReferences to Aliases with collated expression trees. Also, add a flag just in case this change is too invasive.
Why are the changes needed?
This is a followup for #50192.
AttributeReferences toAliases need to receive new names as well, since they reference those aliases.Does this PR introduce any user-facing change?
Yes,
AttributeReferencethat referenceAliases with collated expression trees get new names as well.How was this patch tested?
New golden file tests in collations.sql.
Was this patch authored or co-authored using generative AI tooling?
No.