Skip to content

Conversation

@mridulm
Copy link
Contributor

@mridulm mridulm commented Apr 23, 2014

mvn test fails (intermittently) due to thread leak - since scalatest runs all tests in same vm.

Mridul Muralidharan added 2 commits April 23, 2014 15:06
@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@mridulm mridulm changed the title Fix thread leak SPARK-1587 Fix thread leak Apr 23, 2014
@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14369/

@mridulm
Copy link
Contributor Author

mridulm commented Apr 23, 2014

CC @tdas probably leftovers from the gc patch ?

@tdas
Copy link
Contributor

tdas commented Apr 23, 2014

Maybe! Though could be that some of them were missing from even before! Good catch!

@mridulm
Copy link
Contributor Author

mridulm commented Apr 23, 2014

not some, i think most :-)
wanted to run this past you since you have better context in case i am missing something

@tdas
Copy link
Contributor

tdas commented Apr 23, 2014

From the casual look through, I didnt see anything that breaks any of the cleaning stuff. So LGTM.

@aarondav
Copy link
Contributor

Looks good to me too -- didn't check too much for further missing pieces, but what's here seems good to go. Merged into master and branch-1.0.

@asfgit asfgit closed this in dd681f5 Apr 24, 2014
asfgit pushed a commit that referenced this pull request Apr 24, 2014
mvn test fails (intermittently) due to thread leak - since scalatest runs all tests in same vm.

Author: Mridul Muralidharan <mridulm80@apache.org>

Closes #504 from mridulm/resource_leak_fixes and squashes the following commits:

a5d10d0 [Mridul Muralidharan] Prevent thread leaks while running tests : cleanup all threads when SparkContext.stop is invoked. Causes tests to fail
7b5e19c [Mridul Muralidharan] Prevent NPE while running tests

(cherry picked from commit dd681f5)
Signed-off-by: Aaron Davidson <aaron@databricks.com>
@aarondav aarondav mentioned this pull request Apr 24, 2014
asfgit pushed a commit that referenced this pull request Apr 25, 2014
Oopsie in #504.

Author: Aaron Davidson <aaron@databricks.com>

Closes #527 from aarondav/stop and squashes the following commits:

8d1446a [Aaron Davidson] Call correct stop().
asfgit pushed a commit that referenced this pull request Apr 25, 2014
Oopsie in #504.

Author: Aaron Davidson <aaron@databricks.com>

Closes #527 from aarondav/stop and squashes the following commits:

8d1446a [Aaron Davidson] Call correct stop().
(cherry picked from commit 45ad7f0)

Signed-off-by: Patrick Wendell <pwendell@gmail.com>
pwendell pushed a commit to pwendell/spark that referenced this pull request May 12, 2014
Fix PySpark hang when input files are deleted (SPARK-1025)

This pull request addresses [SPARK-1025](https://spark-project.atlassian.net/browse/SPARK-1025), an issue where PySpark could hang if its input files were deleted.
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
mvn test fails (intermittently) due to thread leak - since scalatest runs all tests in same vm.

Author: Mridul Muralidharan <mridulm80@apache.org>

Closes apache#504 from mridulm/resource_leak_fixes and squashes the following commits:

a5d10d0 [Mridul Muralidharan] Prevent thread leaks while running tests : cleanup all threads when SparkContext.stop is invoked. Causes tests to fail
7b5e19c [Mridul Muralidharan] Prevent NPE while running tests
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
Oopsie in apache#504.

Author: Aaron Davidson <aaron@databricks.com>

Closes apache#527 from aarondav/stop and squashes the following commits:

8d1446a [Aaron Davidson] Call correct stop().
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
Fix PySpark hang when input files are deleted (SPARK-1025)

This pull request addresses [SPARK-1025](https://spark-project.atlassian.net/browse/SPARK-1025), an issue where PySpark could hang if its input files were deleted.
(cherry picked from commit c40619d)

Signed-off-by: Patrick Wendell <pwendell@gmail.com>
yifeih pushed a commit to yifeih/spark that referenced this pull request Mar 5, 2019
…#504)

This one is really hard to deal with. Since internally we have used `yyyy-MM-dd HH:mm:ss.S` as a default SimpleDateFormat there's no way to keep STRICT parsing and not accidentally cause a failure. This will require rewriting data with any timestamps that have csv
yifeih pushed a commit to yifeih/spark that referenced this pull request Mar 5, 2019
…apache#504)" (apache#505)

Reverts palantir#504

This pr is not necessary. After more debugging it looks like it's not possible to replicate `yyyy-MM-dd HH:mm:ss.S` SDF format in java.time.
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
Add a pipeline to trigger acceptance tests against
OpenStack Stein release when comment 'recheck stable/stein'
in pull request.

Related: theopenlab/openlab#231
arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants